refactor(@angular-devkit/build-angular): remove direct require usage from Angular version check#27185
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Mar 4, 2024
Conversation
…from Angular version check To support future package building as ESM, the direct usage of require has now been removed from the Angular compatibility check code used by various builders. Additionally, the limited use of `@angular-devkit/core` has also been removed from the check code as it was only used to adjust string values for error messages which can be done directly instead.
clydin
force-pushed
the
build-angular-esm-compliance-1
branch
from
ac3bcdb to
c63c00a
Compare
clydin
added
the
action: review
alan-agius4
approved these changes
Mar 4, 2024
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support future package building as ESM, the direct usage of require has now been removed from the Angular compatibility check code used by various builders. Additionally, the limited use of
@angular-devkit/corehas also been removed from the check code as it was only used to adjust string values for error messages which can be done directly instead.